Set session cookie secure flag based on NODE_ENV#3939
Open
Nishthajain7 wants to merge 5 commits into
Open
Conversation
yugalkaushik
approved these changes
May 9, 2026
Contributor
yugalkaushik
left a comment
yugalkaushik
left a comment
There was a problem hiding this comment.
@ksen0 the changes look good. This is a great and clean fix that keeps development environments unaffected while properly improving session cookie security. Even though production realistically should never run over plain HTTP, it is still great to enforce secure: true in production as an additional safety measure. Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3909
Problem
The session cookie was currently configured with
secure: falseChanges:
Update the session configuration to conditionally enable the secure flag when running in production.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123